Completed tic tac toe #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to use commits even if you're working on a project by yourself! |
|
|
||
| } | ||
| TicTacToe.prototype.CheckRow = function(col, row, sign) { | ||
| if (row === 0) { |
There was a problem hiding this comment.
The indentation of this conditional vs the {} that are associated with each condition do not seem to match up. Watch out for creating conditionals without the {} because this can cause unexpected behavior.
|
I think you've done a nice job implementing the requirements, but I think there are a lot of opportunities for refactoring. I would love to see you do this refactor to simplify and consolidate your code. Let me know if you do this and would like me to take a look! |
|
I'll continue to work on it during this week and will let you know when I'm done so you can take another look. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please come and play tic tac toe!
The game is played on a 3x3 grid.
Each player, in turn, selects one available grid spot
Upon selecting (clicking), the spot is marked as belonging to that player
If a player claims three spots in a row (horizontally, vertically, or diagonally), they win!
I completed all the requirements, and would love to DRY my code more.